| yuja |
| hg-reviewers |
This patch also adds a review comment which is helpful as inline comment.
| Lint Skipped |
| Unit Tests Skipped |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/scmutil.py (4 lines) |
| 2) 'nowarn': don't warn while unhiding changesets | 2) 'nowarn': don't warn while unhiding changesets | ||||
| returns a repo object with the required changesets unhidden | returns a repo object with the required changesets unhidden | ||||
| """ | """ | ||||
| if not repo.filtername or not repo.ui.configbool('experimental', | if not repo.filtername or not repo.ui.configbool('experimental', | ||||
| 'directaccess'): | 'directaccess'): | ||||
| return repo | return repo | ||||
| if not repo.filtername.startswith('visible'): | if not repo.filtername in ('visible', 'visible-hidden'): | ||||
| return repo | return repo | ||||
| symbols = set() | symbols = set() | ||||
| for spec in specs: | for spec in specs: | ||||
| try: | try: | ||||
| tree = revsetlang.parse(spec) | tree = revsetlang.parse(spec) | ||||
| except error.ParseError: # will be reported by scmutil.revrange() | except error.ParseError: # will be reported by scmutil.revrange() | ||||
| continue | continue | ||||
| return repo | return repo | ||||
| if hiddentype == 'warn': | if hiddentype == 'warn': | ||||
| unfi = repo.unfiltered() | unfi = repo.unfiltered() | ||||
| revstr = ", ".join([pycompat.bytestr(unfi[l]) for l in revs]) | revstr = ", ".join([pycompat.bytestr(unfi[l]) for l in revs]) | ||||
| repo.ui.warn(_("warning: accessing hidden changesets for write " | repo.ui.warn(_("warning: accessing hidden changesets for write " | ||||
| "operation: %s\n") % revstr) | "operation: %s\n") % revstr) | ||||
| # we have to use new filtername to separate branch/tags cache until we can | |||||
| # disbale these cache when revisions are dynamically pinned. | |||||
| return repo.filtered('visible-hidden', revs) | return repo.filtered('visible-hidden', revs) | ||||
| def _getrevsfromsymbols(repo, symbols): | def _getrevsfromsymbols(repo, symbols): | ||||
| """parse the list of symbols and returns a set of revision numbers of hidden | """parse the list of symbols and returns a set of revision numbers of hidden | ||||
| changesets present in symbols""" | changesets present in symbols""" | ||||
| revs = set() | revs = set() | ||||
| unfi = repo.unfiltered() | unfi = repo.unfiltered() | ||||
| unficl = unfi.changelog | unficl = unfi.changelog | ||||