This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1764

revlog: don't use slicing to return parents
ClosedPublic

Authored by indygreg on Dec 26 2017, 7:35 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGa0fab647a8f1: revlog: don't use slicing to return parents
Summary

This is the only place we use a slice on index entries, which
are currently tuples. In preparation for moving away from tuples,
let's stop using slices so we don't have to implement that support
on the new type.

We also tweak the logic slightly so the exception only catches the
IndexError on the index lookup, not on the index entry lookup. The
old code should never have been buggy. But it was semantically wrong.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Dec 26 2017, 7:35 PM
yuja accepted this revision.Jan 5 2018, 12:48 AM
This revision is now accepted and ready to land.Jan 5 2018, 12:48 AM
Closed by commit rHGa0fab647a8f1: revlog: don't use slicing to return parents (authored by indygreg). · Explain WhyJan 5 2018, 1:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (4 lines)

Diff 4702

mercurial/revlog.py

self._chainbasecache[rev] = base self._chainbasecache[rev] = base
return base return base
def linkrev(self, rev): def linkrev(self, rev):
return self.index[rev][4] return self.index[rev][4]
def parentrevs(self, rev): def parentrevs(self, rev):
try: try:
return self.index[rev][5:7] entry = self.index[rev]
except IndexError: except IndexError:
if rev == wdirrev: if rev == wdirrev:
raise error.WdirUnsupported raise error.WdirUnsupported
raise raise
return entry[5], entry[6]
def node(self, rev): def node(self, rev):
try: try:
return self.index[rev][7] return self.index[rev][7]
except IndexError: except IndexError:
if rev == wdirrev: if rev == wdirrev:
raise error.WdirUnsupported raise error.WdirUnsupported
raise raise