This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1766

cext: rename variable describing format for index entries
AcceptedPublic

Authored by indygreg on Dec 26 2017, 7:35 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Summary

"tuple_format" is ambiguous.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Dec 26 2017, 7:35 PM
durin42 accepted this revision.Jan 10 2018, 5:54 PM
This revision is now accepted and ready to land.Jan 10 2018, 5:54 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/revlog.c (6 lines)

Diff 4627

mercurial/cext/revlog.c

} }
static PyObject *nullentry; static PyObject *nullentry;
static const char nullid[20]; static const char nullid[20];
static Py_ssize_t inline_scan(indexObject *self, const char **offsets); static Py_ssize_t inline_scan(indexObject *self, const char **offsets);
#if LONG_MAX == 0x7fffffffL #if LONG_MAX == 0x7fffffffL
static char *tuple_format = "Kiiiiiis#"; static char *index_entry_format = "Kiiiiiis#";
#else #else
static char *tuple_format = "kiiiiiis#"; static char *index_entry_format = "kiiiiiis#";
#endif #endif
/* A RevlogNG v1 index entry is 64 bytes long. */ /* A RevlogNG v1 index entry is 64 bytes long. */
static const long v1_hdrsize = 64; static const long v1_hdrsize = 64;
/* /*
* Return a pointer to the beginning of a RevlogNG record. * Return a pointer to the beginning of a RevlogNG record.
*/ */
comp_len = getbe32(data + 8); comp_len = getbe32(data + 8);
uncomp_len = getbe32(data + 12); uncomp_len = getbe32(data + 12);
base_rev = getbe32(data + 16); base_rev = getbe32(data + 16);
link_rev = getbe32(data + 20); link_rev = getbe32(data + 20);
parent_1 = getbe32(data + 24); parent_1 = getbe32(data + 24);
parent_2 = getbe32(data + 28); parent_2 = getbe32(data + 28);
c_node_id = data + 32; c_node_id = data + 32;
entry = Py_BuildValue(tuple_format, offset_flags, comp_len, entry = Py_BuildValue(index_entry_format, offset_flags, comp_len,
uncomp_len, base_rev, link_rev, uncomp_len, base_rev, link_rev,
parent_1, parent_2, c_node_id, 20); parent_1, parent_2, c_node_id, 20);
if (entry) { if (entry) {
PyObject_GC_UnTrack(entry); PyObject_GC_UnTrack(entry);
Py_INCREF(entry); Py_INCREF(entry);
} }