This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	pulkit	D1800 py3: add 8 new passing tests to the whitelist
Closed	pulkit	D1799 py3: use list() to get a list of items using dict.items()
Closed	pulkit	D1798 py3: convert dict keys' to str before passing as kwargs
Closed	pulkit	D1797 py3: make sure we open the file to write in bytes mode
Closed	pulkit	D1796 py3: don't use dict.iterkeys()
Closed	pulkit	D1795 py3: use pycompat.bytestr() instead of str()
Closed	pulkit	D1794 py3: make regular expressions bytes by prepending b''
Closed	pulkit	D1793 py3: slice on bytes instead of indexing
Closed	pulkit	D1792 py3: use node.hex(h.digest()) instead of h.hexdigest()
Closed	pulkit	D1791 tests: make autodiff.py work on Python 3
Closed	pulkit	D1790 py3: use pycompat.ziplist instead of inbuilt zip
Closed	pulkit	D1789 py3: use bytes and open() instead of file() in test-diff-upgrade.t
Closed	pulkit	D1788 tests: add b'' to string literals where bytes are required

Diff 4780

mercurial/subrepo.py


	Each remote repo requires its own store hash cache, because a subrepo			Each remote repo requires its own store hash cache, because a subrepo
	store may be "clean" versus a given remote repo, but not versus another			store may be "clean" versus a given remote repo, but not versus another
	'''			'''
	cachefile = _getstorehashcachename(remotepath)			cachefile = _getstorehashcachename(remotepath)
	with self._repo.lock():			with self._repo.lock():
	storehash = list(self._calcstorehash(remotepath))			storehash = list(self._calcstorehash(remotepath))
	vfs = self._cachestorehashvfs			vfs = self._cachestorehashvfs
	vfs.writelines(cachefile, storehash, mode='w', notindexed=True)			vfs.writelines(cachefile, storehash, mode='wb', notindexed=True)

	def _getctx(self):			def _getctx(self):
	'''fetch the context for this subrepo revision, possibly a workingctx			'''fetch the context for this subrepo revision, possibly a workingctx
	'''			'''
	if self._ctx.rev() is None:			if self._ctx.rev() is None:
	return self._repo[None] # workingctx if parent is workingctx			return self._repo[None] # workingctx if parent is workingctx
	else:			else:
	rev = self._state[1]			rev = self._state[1]
	self.ui.setconfig('paths', key, value, 'subrepo')			self.ui.setconfig('paths', key, value, 'subrepo')

	defpath = _abssource(self._repo, abort=False)			defpath = _abssource(self._repo, abort=False)
	defpushpath = _abssource(self._repo, True, abort=False)			defpushpath = _abssource(self._repo, True, abort=False)
	addpathconfig('default', defpath)			addpathconfig('default', defpath)
	if defpath != defpushpath:			if defpath != defpushpath:
	addpathconfig('default-push', defpushpath)			addpathconfig('default-push', defpushpath)

	fp = self._repo.vfs("hgrc", "w", text=True)			fp = self._repo.vfs("hgrc", "wb", text=True)
				yujaUnsubmitted Not Done No. Here we explicitly states that we want to open a file in "text" mode. Needs something like ac69675fff1c. yuja: No. Here we explicitly states that we want to open a file in "text" mode. Needs something like…
	try:			try:
	fp.write(''.join(lines))			fp.write(''.join(lines))
	finally:			finally:
	fp.close()			fp.close()

	@annotatesubrepoerror			@annotatesubrepoerror
	def add(self, ui, match, prefix, explicitonly, **opts):			def add(self, ui, match, prefix, explicitonly, **opts):
	return cmdutil.add(ui, self._repo, match,			return cmdutil.add(ui, self._repo, match,

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	4674		Dec 28 2017, 7:49 PM	★	★
Diff 2	4780	rHGf2f0a777b2e28dceb003ea9ce05412b9f6013d06	Dec 28 2017, 6:59 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

py3: make sure we open the file to write in bytes modeClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4780

mercurial/subrepo.py

py3: make sure we open the file to write in bytes mode
ClosedPublic

Revision Contents
Changeset List