This is an archive of the discontinued Mercurial Phabricator instance.

contrib: add git-sl emulation of hg smartlog
ClosedPublic

Authored by simonfar on Jul 24 2017, 9:02 AM.
Tags
None
Subscribers
quark, Restricted Project

Details

Reviewers
durham
ryanmce
quark
Group Reviewers
Restricted Project
Commits
rFBHGXba70497b5340: contrib: add git-sl emulation of hg smartlog
Summary

git-sl is a script to emulate some of hg smartlog, but for git. It's generally
useful, and demonstrates some of our thinking around source control, so let's
release it to the world.

Test Plan

Just for documentation

Ran tests - only test-check-commit-hg.t fails, but that does not run on public
commits, so this is safe to land (unlike the previous attempt).

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

simonfar created this revision.Jul 24 2017, 9:02 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 24 2017, 9:02 AM
ryanmce edited edge metadata.Jul 24 2017, 9:57 AM

How does test-check-commit.t fail with this?

It complains about the code style not matching Mercurial code style. As this is never going to be part of Mercurial, I'm not keen on spending time fixing coding style.

As the test won't complain about public commits, I left it alone - other tests that check code pass.

quark accepted this revision.Jul 26 2017, 6:43 PM
quark added a subscriber: quark.

Since it's for git, I think it's fine to not use the hg code style.

You might want to add # no-check-code if test-check-code-hg.t complains.

This revision is now accepted and ready to land.Jul 26 2017, 6:43 PM

I fixed the complaints from test-check-code - they looked like good complaints to fix (readability issues). It's just test-check-commit that fails, for not being hg coding style.

This revision was automatically updated to reflect the committed changes.