phabricator: add a template item for linking to a differential review
ClosedPublic

Authored by tom.prince on Jan 2 2018, 12:09 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tom.prince created this revision.Jan 2 2018, 12:09 PM
pulkit added a subscriber: pulkit.Jan 10 2018, 3:48 AM
pulkit added inline comments.
contrib/phabricator.py
872

couple of new lines here and above too, did you ran test-check-commit.t?

indygreg requested changes to this revision.Jan 14 2018, 2:31 PM
indygreg added a subscriber: indygreg.

Please also remove the double newlines and fix the commit message to abide by our message standards.

From the tests/ directory, run ./run-tests.py -j8 test-check-* to run the static analysis checks.

contrib/phabricator.py
870–871

registrar.templatekeyword() returns a function that can be used as a decorator. This is the preferred mechanism to define templates in extensions. See hgext/transplant.py for a simple example.

Please switch to that API.

This revision now requires changes to proceed.Jan 14 2018, 2:31 PM
tom.prince updated this revision to Diff 4834.Jan 15 2018, 4:58 PM
tom.prince retitled this revision from Add a template item for linking to a differential review. to phabricator: add a template item for linking to a differential review.
tom.prince marked 2 inline comments as done.Jan 15 2018, 5:00 PM
durin42 accepted this revision.Jan 18 2018, 2:36 PM
durin42 added a subscriber: durin42.

nice, I was about to do this today

This revision was automatically updated to reflect the committed changes.