This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1802

phabricator: add a template item for linking to a differential review
ClosedPublic

Authored by tom.prince on Jan 2 2018, 12:09 PM.

Details

Reviewers
indygreg
durin42
Group Reviewers
hg-reviewers
Commits
rHGf18ba40d792f: phabricator: add a template item for linking to a differential review
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tom.prince created this revision.Jan 2 2018, 12:09 PM
pulkit added a subscriber: pulkit.Jan 10 2018, 3:48 AM
pulkit added inline comments.
contrib/phabricator.py
872

couple of new lines here and above too, did you ran test-check-commit.t?

indygreg requested changes to this revision.Jan 14 2018, 2:31 PM
indygreg added a subscriber: indygreg.

Please also remove the double newlines and fix the commit message to abide by our message standards.

From the tests/ directory, run ./run-tests.py -j8 test-check-* to run the static analysis checks.

contrib/phabricator.py
870–871

registrar.templatekeyword() returns a function that can be used as a decorator. This is the preferred mechanism to define templates in extensions. See hgext/transplant.py for a simple example.

Please switch to that API.

This revision now requires changes to proceed.Jan 14 2018, 2:31 PM
tom.prince retitled this revision from Add a template item for linking to a differential review. to phabricator: add a template item for linking to a differential review.Jan 15 2018, 4:58 PM
tom.prince updated this revision to Diff 4834.
tom.prince marked 2 inline comments as done.Jan 15 2018, 5:00 PM
durin42 accepted this revision.Jan 18 2018, 2:36 PM
durin42 added a subscriber: durin42.

nice, I was about to do this today

Closed by commit rHGf18ba40d792f: phabricator: add a template item for linking to a differential review (authored by tom.prince). · Explain WhyJan 18 2018, 2:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/phabricator.py (14 lines)

Diff 4926

contrib/phabricator.py

drevs = querydrev(repo, spec) drevs = querydrev(repo, spec)
for i, drev in enumerate(drevs): for i, drev in enumerate(drevs):
if i + 1 == len(drevs) and opts.get('comment'): if i + 1 == len(drevs) and opts.get('comment'):
actions.append({'type': 'comment', 'value': opts['comment']}) actions.append({'type': 'comment', 'value': opts['comment']})
if actions: if actions:
params = {'objectIdentifier': drev[r'phid'], params = {'objectIdentifier': drev[r'phid'],
'transactions': actions} 'transactions': actions}
callconduit(repo, 'differential.revision.edit', params) callconduit(repo, 'differential.revision.edit', params)
templatekeyword = registrar.templatekeyword()
@templatekeyword('phabreview')
indygregUnsubmitted
Done

registrar.templatekeyword() returns a function that can be used as a decorator. This is the preferred mechanism to define templates in extensions. See hgext/transplant.py for a simple example.

Please switch to that API.

indygreg: `registrar.templatekeyword()` returns a function that can be used as a decorator. This is the…
def template_review(repo, ctx, revcache, **args):
pulkitUnsubmitted
Done

couple of new lines here and above too, did you ran test-check-commit.t?

pulkit: couple of new lines here and above too, did you ran test-check-commit.t?
""":phabreview: Object describing the review for this changeset.
Has attributes `url` and `id`.
"""
m = _differentialrevisiondescre.search(ctx.description())
if m:
return {
'url': m.group('url'),
'id': "D{}".format(m.group('id')),
}