This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1834

pylint: add a check for multiple statement on a single line
ClosedPublic

Authored by lothiraldan on Jan 10 2018, 3:23 AM.

Details

Reviewers
pulkit
indygreg
Group Reviewers
hg-reviewers
Commits
rHG6061e54ff81d: pylint: add a check for multiple statement on a single line
Summary

Now that they are all cleaned up, we can install a check so that no new
occurrence appears.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Jan 10 2018, 3:23 AM
pulkit accepted this revision.Jan 10 2018, 3:45 AM
indygreg accepted this revision.Jan 14 2018, 2:34 PM
indygreg added a subscriber: indygreg.

Nice cleanup. Always happy to turn on more lint checks.

This revision is now accepted and ready to land.Jan 14 2018, 2:34 PM
Closed by commit rHG6061e54ff81d: pylint: add a check for multiple statement on a single line (authored by lothiraldan). · Explain WhyJan 14 2018, 2:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-check-pylint.t (2 lines)

Diff 4822

tests/test-check-pylint.t

#require test-repo pylint hg10 #require test-repo pylint hg10
Run pylint for known rules we care about. Run pylint for known rules we care about.
----------------------------------------- -----------------------------------------
There should be no recorded failures; fix the codebase before introducing a There should be no recorded failures; fix the codebase before introducing a
new check. new check.
Current checks: Current checks:
- W0102: no mutable default argument - W0102: no mutable default argument
$ touch $TESTTMP/fakerc $ touch $TESTTMP/fakerc
$ pylint --rcfile=$TESTTMP/fakerc --disable=all \ $ pylint --rcfile=$TESTTMP/fakerc --disable=all \
> --enable=W0102 \ > --enable=W0102,C0321 \
> --reports=no \ > --reports=no \
> --ignore=thirdparty \ > --ignore=thirdparty \
> mercurial hgdemandimport hgext hgext3rd > mercurial hgdemandimport hgext hgext3rd
(?) (?)
------------------------------------ (?) ------------------------------------ (?)
Your code has been rated at 10.00/10 (?) Your code has been rated at 10.00/10 (?)
(?) (?)