This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	martinvonz	D1841 exchange: use context manager for locks and transaction in unbundle()
Closed	martinvonz	D1840 bookmarks: use context managers for locks and transaction in pushbookmark()
Closed	martinvonz	D1839 bookmarks: use context managers for lock and transaction in update()
Closed	martinvonz	D1838 phase: use context managers for lock and transaction
Closed	martinvonz	D1837 obsolete: use context manager for transaction in pushmarker()
Closed	martinvonz	D1836 obsolete: use context manager for lock in pushmarker()
Closed	martinvonz	D1835 obsolete: use context manager for transaction in createmarkers()

Diff 4759

	deletefrom = [b.node() for b in divs if b.rev() in anc or b == new]			deletefrom = [b.node() for b in divs if b.rev() in anc or b == new]
	if validdest(repo, repo[marks[active]], new):			if validdest(repo, repo[marks[active]], new):
	bmchanges.append((active, new.node()))			bmchanges.append((active, new.node()))

	for bm in divergent2delete(repo, deletefrom, active):			for bm in divergent2delete(repo, deletefrom, active):
	bmchanges.append((bm, None))			bmchanges.append((bm, None))

	if bmchanges:			if bmchanges:
	lock = tr = None			with repo.lock(), repo.transaction('bookmark') as tr:
	try:
	lock = repo.lock()
	tr = repo.transaction('bookmark')
	marks.applychanges(repo, tr, bmchanges)			marks.applychanges(repo, tr, bmchanges)
	tr.close()
	finally:
	lockmod.release(tr, lock)
	return bool(bmchanges)			return bool(bmchanges)

	def listbinbookmarks(repo):			def listbinbookmarks(repo):
	# We may try to list bookmarks on a repo type that does not			# We may try to list bookmarks on a repo type that does not
	# support it (e.g., statichttprepository).			# support it (e.g., statichttprepository).
	marks = getattr(repo, '_bookmarks', {})			marks = getattr(repo, '_bookmarks', {})

	hasnode = repo.changelog.hasnode			hasnode = repo.changelog.hasnode