This is an archive of the discontinued Mercurial Phabricator instance.

repair: filter out unknown revisions from phasecache within transaction
ClosedPublic

Authored by martinvonz on Jan 16 2018, 2:33 AM.

Details

Summary

I'm about to add another summary report callback that needs to access
phase information. These callbacks run at the end of the transaction
and some of them failed because they tried to get the phase for
stripped commits. The solution is to filter out unknown revisions
before the transaction is closed.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 16 2018, 2:33 AM
yuja accepted this revision.Jan 18 2018, 8:14 AM
This revision is now accepted and ready to land.Jan 18 2018, 8:14 AM
This revision was automatically updated to reflect the committed changes.