This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1868

evolution: make reporting of new unstable changesets optional
ClosedPublic

Authored by martinvonz on Jan 16 2018, 2:33 AM.

Details

Reviewers
lothiraldan
yuja
Group Reviewers
hg-reviewers
Commits
rHG5cd60b0587a8: evolution: make reporting of new unstable changesets optional
Summary

This makes it possible to turn off the reporting of unstable
changesets (e.g. "1 new orphan changesets"), just in case it's too
slow for some users. Anyone who's been using the evolve extension has
already been accepting the cost of the reporting, so this is just for
the few users who have turned on obsmarkers but not been using the
evolve extension (as I believe Facebook has).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 16 2018, 2:33 AM
lothiraldan accepted this revision.Jan 17 2018, 1:56 PM
yuja accepted this revision.Jan 18 2018, 8:14 AM
This revision is now accepted and ready to land.Jan 18 2018, 8:14 AM
Closed by commit rHG5cd60b0587a8: evolution: make reporting of new unstable changesets optional (authored by martinvonz). · Explain WhyJan 18 2018, 8:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/configitems.py (3 lines)
Mmercurial/scmutil.py (3 lines)
Mtests/test-obsolete.t (11 lines)

Diff 4899

mercurial/configitems.py

alias=[('experimental', 'effect-flags')] alias=[('experimental', 'effect-flags')]
) )
coreconfigitem('experimental', 'evolution.exchange', coreconfigitem('experimental', 'evolution.exchange',
default=None, default=None,
) )
coreconfigitem('experimental', 'evolution.bundle-obsmarker', coreconfigitem('experimental', 'evolution.bundle-obsmarker',
default=False, default=False,
) )
coreconfigitem('experimental', 'evolution.report-instabilities',
default=True,
)
coreconfigitem('experimental', 'evolution.track-operation', coreconfigitem('experimental', 'evolution.track-operation',
default=True, default=True,
) )
coreconfigitem('experimental', 'worddiff', coreconfigitem('experimental', 'worddiff',
default=False, default=False,
) )
coreconfigitem('experimental', 'maxdeltachainspan', coreconfigitem('experimental', 'maxdeltachainspan',
default=-1, default=-1,

mercurial/scmutil.py

if txmatch(_reportobsoletedsource): if txmatch(_reportobsoletedsource):
@reportsummary @reportsummary
def reportobsoleted(repo, tr): def reportobsoleted(repo, tr):
obsoleted = obsutil.getobsoleted(repo, tr) obsoleted = obsutil.getobsoleted(repo, tr)
if obsoleted: if obsoleted:
repo.ui.status(_('obsoleted %i changesets\n') repo.ui.status(_('obsoleted %i changesets\n')
% len(obsoleted)) % len(obsoleted))
if obsolete.isenabled(repo, obsolete.createmarkersopt): if (obsolete.isenabled(repo, obsolete.createmarkersopt) and
repo.ui.configbool('experimental', 'evolution.report-instabilities')):
instabilitytypes = [ instabilitytypes = [
('orphan', 'orphan'), ('orphan', 'orphan'),
('phase-divergent', 'phasedivergent'), ('phase-divergent', 'phasedivergent'),
('content-divergent', 'contentdivergent'), ('content-divergent', 'contentdivergent'),
] ]
def getinstabilitycounts(repo): def getinstabilitycounts(repo):
filtered = repo.changelog.filteredrevs filtered = repo.changelog.filteredrevs

tests/test-obsolete.t

branch: default branch: default
latesttag: null latesttag: null
latesttagdistance: 2 latesttagdistance: 2
changessincelatesttag: 2 changessincelatesttag: 2
$ cd .. $ cd ..
Can disable transaction summary report
$ hg init transaction-summary
$ cd transaction-summary
$ mkcommit a
$ mkcommit b
$ hg up -q null
$ hg --config experimental.evolution.report-instabilities=false debugobsolete `getid a`
obsoleted 1 changesets
$ cd ..
Exchange Test Exchange Test
============================ ============================
Destination repo does not have any data Destination repo does not have any data
--------------------------------------- ---------------------------------------
Simple incoming test Simple incoming test