( )⚙ D1880 blackbox: if --debug is used, also trace ui.debug() calls

This is an archive of the discontinued Mercurial Phabricator instance.

blackbox: if --debug is used, also trace ui.debug() calls
ClosedPublic

Authored by joerg.sonnenberger on Jan 18 2018, 6:56 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuja requested changes to this revision.Jan 18 2018, 7:56 AM
yuja added a subscriber: yuja.

I'm 0 on this, but I have no reason against it.

hgext/blackbox.py
136

These arguments can't be passed directly to .log().
.log() takes a format string and its parameters, whereas .debug()
takes a list of arbitrary strings to print.

Perhaps **opts should be dropped.

This revision now requires changes to proceed.Jan 18 2018, 7:56 AM
joerg.sonnenberger updated this revision to Diff 4903.
joerg.sonnenberger marked an inline comment as done.Jan 18 2018, 1:35 PM
joerg.sonnenberger added inline comments.
hgext/blackbox.py
136

Fixed, thanks.

durin42 accepted this revision.Jan 18 2018, 3:10 PM
joerg.sonnenberger marked an inline comment as done.Jan 18 2018, 3:31 PM
This revision was automatically updated to reflect the committed changes.