( )⚙ D1882 atomicupdate: add an experimental option to use atomictemp when updating

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1882

atomicupdate: add an experimental option to use atomictemp when updating
ClosedPublic

Authored by lothiraldan on Jan 18 2018, 7:38 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG45b678bf3a78: atomicupdate: add an experimental option to use atomictemp when updating
Summary

In some cases Mercurial truncating files when updating causes problems. It can
happens when processes are currently reading the file or with big file or on
NFS mounts.

We add an experimental option to use the atomictemp option of vfs.call in
order to avoid the problem.

The localrepository.wwrite seems to assume the files are created without the
x flag; with atomictempfile, the new file might inherit the x flag from
the destination. We force remove it afterward. This code could be refactored
and the flag processing could be moved inside vfs.

This patch should be tested with
--extra-config-opt experimental.update.atomic-file=True
as we disabled the option by default.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Jan 18 2018, 7:38 AM
durin42 accepted this revision.Jan 18 2018, 3:12 PM
This revision is now accepted and ready to land.Jan 18 2018, 3:12 PM
Closed by commit rHG45b678bf3a78: atomicupdate: add an experimental option to use atomictemp when updating (authored by lothiraldan). · Explain WhyJan 18 2018, 3:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/configitems.py (3 lines)
Mmercurial/localrepo.py (2 lines)
Mmercurial/merge.py (4 lines)

Diff 4930

mercurial/configitems.py

default=0.25, default=0.25,
) )
coreconfigitem('experimental', 'sparse-read.min-gap-size', coreconfigitem('experimental', 'sparse-read.min-gap-size',
default='256K', default='256K',
) )
coreconfigitem('experimental', 'treemanifest', coreconfigitem('experimental', 'treemanifest',
default=False, default=False,
) )
coreconfigitem('experimental', 'update.atomic-file',
default=False,
)
coreconfigitem('extensions', '.*', coreconfigitem('extensions', '.*',
default=None, default=None,
generic=True, generic=True,
) )
coreconfigitem('extdata', '.*', coreconfigitem('extdata', '.*',
default=None, default=None,
generic=True, generic=True,
) )

mercurial/localrepo.py

data = self._filter(self._decodefilterpats, filename, data) data = self._filter(self._decodefilterpats, filename, data)
if 'l' in flags: if 'l' in flags:
self.wvfs.symlink(data, filename) self.wvfs.symlink(data, filename)
else: else:
self.wvfs.write(filename, data, backgroundclose=backgroundclose, self.wvfs.write(filename, data, backgroundclose=backgroundclose,
**kwargs) **kwargs)
if 'x' in flags: if 'x' in flags:
self.wvfs.setflags(filename, False, True) self.wvfs.setflags(filename, False, True)
else:
self.wvfs.setflags(filename, False, False)
return len(data) return len(data)
def wwritedata(self, filename, data): def wwritedata(self, filename, data):
return self._filter(self._decodefilterpats, filename, data) return self._filter(self._decodefilterpats, filename, data)
def currenttransaction(self): def currenttransaction(self):
"""return the current transaction or None if non exists""" """return the current transaction or None if non exists"""
if self._transref: if self._transref:

mercurial/merge.py

for p in util.finddirs(f): for p in util.finddirs(f):
if repo.wvfs.isfileorlink(p): if repo.wvfs.isfileorlink(p):
absf = repo.wjoin(p) absf = repo.wjoin(p)
break break
orig = scmutil.origpath(ui, repo, absf) orig = scmutil.origpath(ui, repo, absf)
if repo.wvfs.lexists(absf): if repo.wvfs.lexists(absf):
util.rename(absf, orig) util.rename(absf, orig)
wctx[f].clearunknown() wctx[f].clearunknown()
wctx[f].write(fctx(f).data(), flags, backgroundclose=True) atomictemp = ui.configbool("experimental", "update.atomic-file")
wctx[f].write(fctx(f).data(), flags, backgroundclose=True,
atomictemp=atomictemp)
if i == 100: if i == 100:
yield i, f yield i, f
i = 0 i = 0
i += 1 i += 1
if i > 0: if i > 0:
yield i, f yield i, f