This is an archive of the discontinued Mercurial Phabricator instance.

localrepo: consistently use native str when __dict__ is involved
ClosedPublic

Authored by durin42 on Jan 18 2018, 8:39 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Jan 18 2018, 8:39 AM
pulkit accepted this revision.Jan 18 2018, 9:00 AM
durin42 edited the summary of this revision. (Show Details)Jan 18 2018, 1:37 PM

I think this should not be a skip-blame. We are adding a call to pycompat.sysstr too.

durin42 updated this revision to Diff 4950.Jan 19 2018, 3:12 PM
pulkit accepted this revision.Jan 20 2018, 5:20 AM

Looks good, the skip-blame part in commit message can be dropped during flight.

durin42 updated this revision to Diff 5043.Feb 1 2018, 3:05 PM
indygreg accepted this revision.Feb 1 2018, 3:38 PM
indygreg added a subscriber: indygreg.

Dropped skip-blame in flight.

This revision is now accepted and ready to land.Feb 1 2018, 3:38 PM
This revision was automatically updated to reflect the committed changes.