This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	durin42	D20 check-code: prohibit `if False` antipattern
Closed	durin42	D19 convert: remove `if False` block
Closed	durin42	D18 filterpyflakes: move self-test into test file

Diff 34

	f.close()			f.close()
	if 'no-' 'check-code' in data:			if 'no-' 'check-code' in data:
	continue			continue
	lines.append(line)			lines.append(line)

	for line in lines:			for line in lines:
	sys.stdout.write(line)			sys.stdout.write(line)
	print()			print()

	# self test of "undefined name" detection
	if False:
	print(undefinedname)

	#require test-repo pyflakes hg10			#require test-repo pyflakes hg10

	$ . "$TESTDIR/helpers-testrepo.sh"			$ . "$TESTDIR/helpers-testrepo.sh"
	$ cd "`dirname "$TESTDIR"`"			$ cd "`dirname "$TESTDIR"`"

	run pyflakes on all tracked files ending in .py or without a file ending			run pyflakes on all tracked files ending in .py or without a file ending
	(skipping binary file random-seed)			(skipping binary file random-seed)

				$ cat > test.py <<EOF
				> print(undefinedname)
				> EOF
				krbullockUnsubmitted Not Done Adding an inline comment on this cute heredoc to test how they come thru via e-mail. krbullock: Adding an inline comment on this cute heredoc to test how they come thru via e-mail.
				$ pyflakes test.py 2>/dev/null \| "$TESTDIR/filterpyflakes.py"
				test.py:1: undefined name 'undefinedname'


	$ testrepohg locate 'set:*.py or grep("^#!.python")' \			$ testrepohg locate 'set:*.py or grep("^#!.python")' \
	> -X hgext/fsmonitor/pywatchman \			> -X hgext/fsmonitor/pywatchman \
	> -X mercurial/pycompat.py -X contrib/python-zstandard \			> -X mercurial/pycompat.py -X contrib/python-zstandard \
	> 2>/dev/null \			> 2>/dev/null \
	> \| xargs pyflakes 2>/dev/null \| "$TESTDIR/filterpyflakes.py"			> \| xargs pyflakes 2>/dev/null \| "$TESTDIR/filterpyflakes.py"
	tests/filterpyflakes.py:41: undefined name 'undefinedname'