This is an archive of the discontinued Mercurial Phabricator instance.

Differential D18

filterpyflakes: move self-test into test file
ClosedPublic

Authored by durin42 on Jul 10 2017, 2:28 PM.
Tags
None
Subscribers
reviewers

Details

Reviewers
krbullock
Commits
rHG6029939f7e98: filterpyflakes: move self-test into test file
Summary

This will avoid a false positive on an upcoming check-code rule.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jul 10 2017, 2:28 PM
durin42 added a child revision: D19: convert: remove `if False` block.
krbullock accepted this revision.Jul 10 2017, 2:42 PM
This revision is now accepted and ready to land.Jul 10 2017, 2:42 PM
krbullock added a comment.Jul 10 2017, 3:04 PM

LGTM. Commenting to test Herald rules.

krbullock added inline comments.Jul 10 2017, 3:05 PM
tests/test-check-pyflakes.t
11

Adding an inline comment on this cute heredoc to test how they come thru via e-mail.

Closed by commit rHG6029939f7e98: filterpyflakes: move self-test into test file (authored by durin42). · Explain WhyJul 12 2017, 4:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/filterpyflakes.py (4 lines)
Mtests/test-check-pyflakes.t (8 lines)

Diff 89

tests/filterpyflakes.py

f.close() f.close()
if 'no-' 'check-code' in data: if 'no-' 'check-code' in data:
continue continue
lines.append(line) lines.append(line)
for line in lines: for line in lines:
sys.stdout.write(line) sys.stdout.write(line)
print() print()
# self test of "undefined name" detection
if False:
print(undefinedname)

tests/test-check-pyflakes.t

#require test-repo pyflakes hg10 #require test-repo pyflakes hg10
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
$ cd "`dirname "$TESTDIR"`" $ cd "`dirname "$TESTDIR"`"
run pyflakes on all tracked files ending in .py or without a file ending run pyflakes on all tracked files ending in .py or without a file ending
(skipping binary file random-seed) (skipping binary file random-seed)
$ cat > test.py <<EOF
> print(undefinedname)
> EOF
krbullockUnsubmitted
Not Done

Adding an inline comment on this cute heredoc to test how they come thru via e-mail.

krbullock: Adding an inline comment on this cute heredoc to test how they come thru via e-mail.
$ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py"
test.py:1: undefined name 'undefinedname'
$ testrepohg locate 'set:**.py or grep("^#!.*python")' \ $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
> -X hgext/fsmonitor/pywatchman \ > -X hgext/fsmonitor/pywatchman \
> -X mercurial/pycompat.py -X contrib/python-zstandard \ > -X mercurial/pycompat.py -X contrib/python-zstandard \
> 2>/dev/null \ > 2>/dev/null \
> | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py" > | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
tests/filterpyflakes.py:41: undefined name 'undefinedname'