This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1918

localrepo: run cache-warming transaction callback before report callback
ClosedPublic

Authored by martinvonz on Jan 19 2018, 3:51 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG3a3b59bbe7ce: localrepo: run cache-warming transaction callback before report callback
Summary

See in-code comment for details.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Jan 19 2018, 3:51 PM
durin42 accepted this revision.Jan 19 2018, 3:59 PM
This revision is now accepted and ready to land.Jan 19 2018, 3:59 PM
Closed by commit rHG3a3b59bbe7ce: localrepo: run cache-warming transaction callback before report callback (authored by martinvonz). · Explain WhyJan 19 2018, 4:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4956

mercurial/localrepo.py

args.update(phases.preparehookargs(node, old, new)) args.update(phases.preparehookargs(node, old, new))
repo.hook('txnclose-phase', throw=False, txnname=desc, repo.hook('txnclose-phase', throw=False, txnname=desc,
**pycompat.strkwargs(args)) **pycompat.strkwargs(args))
repo.hook('txnclose', throw=False, txnname=desc, repo.hook('txnclose', throw=False, txnname=desc,
**pycompat.strkwargs(hookargs)) **pycompat.strkwargs(hookargs))
reporef()._afterlock(hookfunc) reporef()._afterlock(hookfunc)
tr.addfinalize('txnclose-hook', txnclosehook) tr.addfinalize('txnclose-hook', txnclosehook)
tr.addpostclose('warms-cache', self._buildcacheupdater(tr)) # Include a leading "-" to make it happen before the transaction summary
# reports registered via scmutil.registersummarycallback() whose names
# are 00-txnreport etc. That way, the caches will be warm when the
# callbacks run.
tr.addpostclose('-warm-cache', self._buildcacheupdater(tr))
def txnaborthook(tr2): def txnaborthook(tr2):
"""To be run if transaction is aborted """To be run if transaction is aborted
""" """
reporef().hook('txnabort', throw=False, txnname=desc, reporef().hook('txnabort', throw=False, txnname=desc,
**tr2.hookargs) **tr2.hookargs)
tr.addabort('txnabort-hook', txnaborthook) tr.addabort('txnabort-hook', txnaborthook)
# avoid eager cache invalidation. in-memory data should be identical # avoid eager cache invalidation. in-memory data should be identical
# to stored data if transaction has no error. # to stored data if transaction has no error.

tests/test-obsolete-changeset-exchange.t

adding foo revisions adding foo revisions
added 1 changesets with 1 changes to 1 files (+1 heads) added 1 changesets with 1 changes to 1 files (+1 heads)
bundle2-input-part: total payload size 476 bundle2-input-part: total payload size 476
bundle2-input-part: "listkeys" (params: 1 mandatory) supported bundle2-input-part: "listkeys" (params: 1 mandatory) supported
bundle2-input-part: "phase-heads" supported bundle2-input-part: "phase-heads" supported
bundle2-input-part: total payload size 24 bundle2-input-part: total payload size 24
bundle2-input-bundle: 2 parts total bundle2-input-bundle: 2 parts total
checking for updated bookmarks checking for updated bookmarks
new changesets bec0734cd68e
updating the branch cache updating the branch cache
new changesets bec0734cd68e
(run 'hg heads' to see heads, 'hg merge' to merge) (run 'hg heads' to see heads, 'hg merge' to merge)