This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1939

ui: Improve performance for multi-component writes
ClosedPublic

Authored by joerg.sonnenberger on Jan 25 2018, 2:01 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGe49c39ffeac2: ui: improve performance for multi-component writes
Summary

It is more efficient to pass down one large string to the output streams
than many small ones. For a `hg diff` test case, it improves time from
2m26s to 2m8s.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuja accepted this revision.Feb 3 2018, 2:55 AM
This revision is now accepted and ready to land.Feb 3 2018, 2:55 AM
Closed by commit rHGe49c39ffeac2: ui: improve performance for multi-component writes (authored by joerg.sonnenberger). · Explain WhyFeb 3 2018, 3:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/ui.py (3 lines)

Diff 5176

mercurial/ui.py

msgs = [self.label(a, label) for a in args] msgs = [self.label(a, label) for a in args]
self._write(*msgs, **opts) self._write(*msgs, **opts)
def _write(self, *msgs, **opts): def _write(self, *msgs, **opts):
self._progclear() self._progclear()
# opencode timeblockedsection because this is a critical path # opencode timeblockedsection because this is a critical path
starttime = util.timer() starttime = util.timer()
try: try:
for a in msgs: self.fout.write(''.join(msgs))
self.fout.write(a)
except IOError as err: except IOError as err:
raise error.StdioError(err) raise error.StdioError(err)
finally: finally:
self._blockedtimes['stdio_blocked'] += \ self._blockedtimes['stdio_blocked'] += \
(util.timer() - starttime) * 1000 (util.timer() - starttime) * 1000
def write_err(self, *args, **opts): def write_err(self, *args, **opts):
self._progclear() self._progclear()