This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1947

configitems: traverse sections deterministically
ClosedPublic

Authored by indygreg on Jan 29 2018, 4:30 PM.

Details

Reviewers
lothiraldan
Group Reviewers
hg-reviewers
Commits
rHG178aacdc25db: configitems: traverse sections deterministically
Summary

Otherwise output can be non-deterministic if there are warnings
for multiple sections.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Jan 29 2018, 4:30 PM
lothiraldan accepted this revision.Jan 30 2018, 3:39 AM
Closed by commit rHG178aacdc25db: configitems: traverse sections deterministically (authored by indygreg). · Explain WhyJan 30 2018, 7:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/configitems.py (2 lines)

Diff 5017

mercurial/configitems.py

from . import ( from . import (
encoding, encoding,
error, error,
) )
def loadconfigtable(ui, extname, configtable): def loadconfigtable(ui, extname, configtable):
"""update config item known to the ui with the extension ones""" """update config item known to the ui with the extension ones"""
for section, items in configtable.items(): for section, items in sorted(configtable.items()):
knownitems = ui._knownconfig.setdefault(section, itemregister()) knownitems = ui._knownconfig.setdefault(section, itemregister())
knownkeys = set(knownitems) knownkeys = set(knownitems)
newkeys = set(items) newkeys = set(items)
for key in sorted(knownkeys & newkeys): for key in sorted(knownkeys & newkeys):
msg = "extension '%s' overwrite config item '%s.%s'" msg = "extension '%s' overwrite config item '%s.%s'"
msg %= (extname, section, key) msg %= (extname, section, key)
ui.develwarn(msg, config='warn-config') ui.develwarn(msg, config='warn-config')