This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1994

config: replace a for-else by any()
ClosedPublic

Authored by martinvonz on Feb 1 2018, 6:30 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGf1a0933ce59e: config: replace a for-else by any()
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Feb 1 2018, 6:30 PM
martinvonz retitled this revision from config: replace a for-else by all() to config: replace a for-else by any().Feb 1 2018, 6:30 PM
indygreg accepted this revision.Feb 1 2018, 6:49 PM
This revision is now accepted and ready to land.Feb 1 2018, 6:49 PM
Closed by commit rHGf1a0933ce59e: config: replace a for-else by any() (authored by martinvonz). · Explain WhyFeb 1 2018, 6:50 PM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Feb 2 2018, 7:24 AM

I'll drop this from hg-committed. Please make sure to touch your local revision
before pulling.

mercurial/commands.py
1674

The variable f is used here.

martinvonz added inline comments.Feb 2 2018, 8:48 AM
mercurial/commands.py
1674

Wow, good catch! Thanks for reading carefully.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (5 lines)

Diff 5141

mercurial/commands.py

if not repo: if not repo:
raise error.Abort(_("can't use --local outside a repository")) raise error.Abort(_("can't use --local outside a repository"))
paths = [repo.vfs.join('hgrc')] paths = [repo.vfs.join('hgrc')]
elif opts.get('global'): elif opts.get('global'):
paths = rcutil.systemrcpath() paths = rcutil.systemrcpath()
else: else:
paths = rcutil.userrcpath() paths = rcutil.userrcpath()
for f in paths: if not any(os.path.exists(f) for f in paths):
if os.path.exists(f):
break
else:
if opts.get('global'): if opts.get('global'):
samplehgrc = uimod.samplehgrcs['global'] samplehgrc = uimod.samplehgrcs['global']
elif opts.get('local'): elif opts.get('local'):
samplehgrc = uimod.samplehgrcs['local'] samplehgrc = uimod.samplehgrcs['local']
else: else:
samplehgrc = uimod.samplehgrcs['user'] samplehgrc = uimod.samplehgrcs['user']
f = paths[0] f = paths[0]
fp = open(f, "wb") fp = open(f, "wb")
fp.write(util.tonativeeol(samplehgrc)) fp.write(util.tonativeeol(samplehgrc))
fp.close() fp.close()
editor = ui.geteditor() editor = ui.geteditor()
ui.system("%s \"%s\"" % (editor, f), ui.system("%s \"%s\"" % (editor, f),
yujaUnsubmitted
Not Done

The variable f is used here.

yuja: The variable `f` is used here.
martinvonzAuthorUnsubmitted
Not Done

Wow, good catch! Thanks for reading carefully.

martinvonz: Wow, good catch! Thanks for reading carefully.
onerr=error.Abort, errprefix=_("edit failed"), onerr=error.Abort, errprefix=_("edit failed"),
blockedtag='config_edit') blockedtag='config_edit')
return return
ui.pager('config') ui.pager('config')
fm = ui.formatter('config', opts) fm = ui.formatter('config', opts)
for t, f in rcutil.rccomponents(): for t, f in rcutil.rccomponents():
if t == 'path': if t == 'path':
ui.debug('read config from: %s\n' % f) ui.debug('read config from: %s\n' % f)