This is an archive of the discontinued Mercurial Phabricator instance.

Differential D19

convert: remove `if False` block
ClosedPublic

Authored by durin42 on Jul 10 2017, 2:28 PM.
Tags
None
Subscribers
reviewers

Details

Reviewers
krbullock
Commits
rHGffb30661f672: convert: remove `if False` block
Summary

This code has never run since its introduction on July 18th,

  1. It's time for it to go.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

krbullock accepted this revision.Jul 10 2017, 2:48 PM
This revision is now accepted and ready to land.Jul 10 2017, 2:48 PM
Closed by commit rHGffb30661f672: convert: remove `if False` block (authored by durin42). · Explain WhyJul 12 2017, 4:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/convert/transport.py (5 lines)

Diff 90

hgext/convert/transport.py

self.svn_url = url self.svn_url = url
self.username = '' self.username = ''
self.password = '' self.password = ''
# Only Subversion 1.4 has reparent() # Only Subversion 1.4 has reparent()
if ra is None or not util.safehasattr(svn.ra, 'reparent'): if ra is None or not util.safehasattr(svn.ra, 'reparent'):
self.client = svn.client.create_context(self.pool) self.client = svn.client.create_context(self.pool)
ab = _create_auth_baton(self.pool) ab = _create_auth_baton(self.pool)
if False:
svn.core.svn_auth_set_parameter(
ab, svn.core.SVN_AUTH_PARAM_DEFAULT_USERNAME, self.username)
svn.core.svn_auth_set_parameter(
ab, svn.core.SVN_AUTH_PARAM_DEFAULT_PASSWORD, self.password)
self.client.auth_baton = ab self.client.auth_baton = ab
global svn_config global svn_config
if svn_config is None: if svn_config is None:
svn_config = svn.core.svn_config_get_config(None) svn_config = svn.core.svn_config_get_config(None)
self.client.config = svn_config self.client.config = svn_config
try: try:
self.ra = svn.client.open_ra_session( self.ra = svn.client.open_ra_session(
self.svn_url, self.svn_url,