This is an archive of the discontinued Mercurial Phabricator instance.

sshpeer: remove frivolous call to _cleanup()
ClosedPublic

Authored by indygreg on Feb 4 2018, 10:35 PM.

Details

Summary

_validaterepo() is called once during init. _cleanup()
no-ops if the self._pipe* attributes aren't set. These attributes
are set during _validaterepo(). So the call to _cleanup() isn't
necessary.

But just to be on the safe side, we add an assertion.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 4 2018, 10:35 PM
lothiraldan accepted this revision.Feb 5 2018, 8:05 AM
yuja accepted this revision.Feb 6 2018, 8:07 AM
This revision is now accepted and ready to land.Feb 6 2018, 8:07 AM
This revision was automatically updated to reflect the committed changes.