This is an archive of the discontinued Mercurial Phabricator instance.

sshpeer: clean up API for sshpeer.__init__ (API)
ClosedPublic

Authored by indygreg on Feb 4 2018, 10:35 PM.

Details

Summary

Our refactoring left the state of sshpeer.init in a poor
state. "create" was no longer used. Process/pipe arguments were
passed poorly. "name" was really a URL.

This commit cleans all that up.

.. api::

sshpeer.sshpeer.__init__ now receives arguments describing an
existing connection instead of creating a connection itself.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 4 2018, 10:35 PM
lothiraldan accepted this revision.Feb 5 2018, 8:13 AM
indygreg updated this revision to Diff 5233.Feb 5 2018, 5:21 PM
yuja accepted this revision.Feb 6 2018, 8:07 AM
This revision is now accepted and ready to land.Feb 6 2018, 8:07 AM
This revision was automatically updated to reflect the committed changes.