This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	pulkit	D2046 py3: add b'' to literals in check-config.py
Closed	pulkit	D2045 check-config: specify the mode 'rb' to open the file
Closed	pulkit	D2044 py3: use open() instead of file()
Closed	pulkit	D2043 py3: use pycompat.strkwargs() to convert kwargs' key to str
Closed	pulkit	D2042 py3: add __bytes__() for mq.patchheader and make sure __str__ returns str
Closed	pulkit	D2041 py3: use "%d" to convert integer to bytes
Closed	pulkit	D2040 py3: use .startswith() instead of bytes[0]
Closed	pulkit	D2039 py3: slice on bytes to prevent getting the ascii values
Closed	pulkit	D2038 py3: add r'' to convert keys to keyword arguments to str
Closed	pulkit	D2037 py3: add b'' to tweakdefualts config string

Diff 5210

	lines = []			lines = []
	if firstline is not None:			if firstline is not None:
	lines.append('%s\n' % firstline)			lines.append('%s\n' % firstline)

	for k, v in data.items():			for k, v in data.items():
	if k == self.firstlinekey:			if k == self.firstlinekey:
	e = "key name '%s' is reserved" % self.firstlinekey			e = "key name '%s' is reserved" % self.firstlinekey
	raise error.ProgrammingError(e)			raise error.ProgrammingError(e)
	if not k[0].isalpha():			if not k[0:1].isalpha():
	e = "keys must start with a letter in a key-value file"			e = "keys must start with a letter in a key-value file"
	raise error.ProgrammingError(e)			raise error.ProgrammingError(e)
	if not k.isalnum():			if not k.isalnum():
	e = "invalid key name in a simple key-value file"			e = "invalid key name in a simple key-value file"
	raise error.ProgrammingError(e)			raise error.ProgrammingError(e)
	if '\n' in v:			if '\n' in v:
	e = "invalid value in a simple key-value file"			e = "invalid value in a simple key-value file"
	raise error.ProgrammingError(e)			raise error.ProgrammingError(e)