This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2045

check-config: specify the mode 'rb' to open the file
ClosedPublic

Authored by pulkit on Feb 5 2018, 3:23 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG143d7b27b09c: check-config: specify the mode 'rb' to open the file
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 5 2018, 3:23 AM
yuja accepted this revision.Feb 5 2018, 9:07 AM
This revision is now accepted and ready to land.Feb 5 2018, 9:07 AM
Closed by commit rHG143d7b27b09c: check-config: specify the mode 'rb' to open the file (authored by pulkit). · Explain WhyFeb 5 2018, 9:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-config.py (2 lines)

Diff 5216

contrib/check-config.py

def main(args): def main(args):
for f in args: for f in args:
sect = '' sect = ''
prevname = '' prevname = ''
confsect = '' confsect = ''
carryover = '' carryover = ''
linenum = 0 linenum = 0
for l in open(f): for l in open(f, 'rb'):
linenum += 1 linenum += 1
# check topic-like bits # check topic-like bits
m = re.match('\s*``(\S+)``', l) m = re.match('\s*``(\S+)``', l)
if m: if m:
prevname = m.group(1) prevname = m.group(1)
if re.match('^\s*-+$', l): if re.match('^\s*-+$', l):
sect = prevname sect = prevname