This is an archive of the discontinued Mercurial Phabricator instance.

lfs: add a test showing bundle application could be broken
ClosedPublic

Authored by quark on Feb 6 2018, 8:14 PM.

Details

Summary

When a bundle containing LFS delta uses non-LFS delta-base, or vice-versa,
the bundle will fail to apply.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Feb 6 2018, 8:14 PM
quark updated this revision to Diff 5268.Feb 6 2018, 8:52 PM
quark updated this revision to Diff 5272.Feb 6 2018, 10:17 PM
quark updated this revision to Diff 5275.Feb 6 2018, 11:43 PM
indygreg accepted this revision.Feb 7 2018, 5:27 PM
This revision is now accepted and ready to land.Feb 7 2018, 5:27 PM
quark updated this revision to Diff 5326.Feb 7 2018, 7:35 PM

This series worked for me in practice. I assume there's no chance that this lands on stable to help people that are pushing to a repo converted to LFS, but that didn't reclone after converting?

tests/test-lfs-bundle.t
23

This needs to be 'url=file:$TESTDIR/lfs-remote' to keep MSYS happy.

quark updated this revision to Diff 5730.Feb 14 2018, 7:42 PM
quark added a comment.Feb 14 2018, 7:59 PM

This series worked for me in practice. I assume there's no chance that this lands on stable to help people that are pushing to a repo converted to LFS, but that didn't reclone after converting?

That should be fine - there is no need to reclone. But upgrading is needed.

indygreg accepted this revision.Mar 6 2018, 12:59 PM
This revision was automatically updated to reflect the committed changes.