This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: remove unused proto argument from supportedcompengines (API)
ClosedPublic

Authored by indygreg on Feb 7 2018, 7:27 PM.

Details

Summary

In theory, the protocol should be passed to this function. But the
argument isn't being used and it is getting in the way of refactoring.
So let's remove it. We can always add it back later if we need it
again.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 7 2018, 7:27 PM
indygreg retitled this revision from wireproto: remove unused proto argument from supportedcompengines to wireproto: remove unused proto argument from supportedcompengines (API).Feb 7 2018, 11:32 PM
indygreg updated this revision to Diff 5338.
indygreg updated this revision to Diff 5349.Feb 8 2018, 12:20 AM
durin42 accepted this revision.Feb 12 2018, 4:23 PM
This revision is now accepted and ready to land.Feb 12 2018, 4:23 PM
This revision was automatically updated to reflect the committed changes.