hg: move share._getsrcrepo into core
ClosedPublic

Authored by indygreg on Mon, Feb 12, 7:31 PM.

Details

Summary

The fact we were calling this from extensions was a sign that it
should live in core.

We were also able to remove some extra attribute aliases from the
share extension.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
indygreg created this revision.Mon, Feb 12, 7:31 PM
pulkit added a subscriber: pulkit.Tue, Feb 13, 4:19 AM

Fb's hg-experimental also uses a utility module just for this function, so I am +1 on moving this to core. https://bitbucket.org/facebook/hg-experimental/src/f27f094e91553d3cae5167c0b1c42ae940f888d5/hgext3rd/shareutil.py

durin42 accepted this revision.Tue, Feb 13, 11:19 AM
This revision is now accepted and ready to land.Tue, Feb 13, 11:19 AM
This revision was automatically updated to reflect the committed changes.