httppeer: remove httpspeer
ClosedPublic

Authored by indygreg on Feb 12 2018, 10:48 PM.

Details

Summary

All it did was verify at construction time that Mercurial supports
TLS. instance() is what's used to construct peer instances. So
we can just inline this check into that function and do away with
the type variant.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
indygreg created this revision.Feb 12 2018, 10:48 PM
lothiraldan accepted this revision.Feb 13 2018, 3:59 AM
lothiraldan added a subscriber: lothiraldan.

Could an extension import the httpspeer class or is it too low-level?

Could an extension import the httpspeer class or is it too low-level?

In theory, sure. But these classes are instantiated via httppeer.instance(). If anything, this change makes things friendlier for extensions because there is one less class to wrap and the remaining class doesn't inherit from a class that may be wrapped.

This revision was automatically updated to reflect the committed changes.