This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2236

tests: remove use of bashism $RANDOM to fix test-narrow.t on non-bash shells
ClosedPublic

Authored by durin42 on Feb 13 2018, 6:02 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG068f520754ca: tests: remove use of bashism $RANDOM to fix test-narrow.t on non-bash shells
Summary

This test passed on our workstations, including on Macs, so we never
noticed, but it fails on both the Linux and FreeBSD buildbots. Today I
learned about a bash feature, wherein $RANDOM gives a random int every
time you read it.

check-code rule to follow.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 13 2018, 6:02 PM
martinvonz accepted this revision.Feb 13 2018, 6:26 PM
This revision is now accepted and ready to land.Feb 13 2018, 6:26 PM
Closed by commit rHG068f520754ca: tests: remove use of bashism $RANDOM to fix test-narrow.t on non-bash shells (authored by durin42). · Explain WhyFeb 13 2018, 6:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-narrow.t (2 lines)

Diff 5665

tests/test-narrow.t

abort: "." and ".." are not allowed in narrowspec paths abort: "." and ".." are not allowed in narrowspec paths
[255] [255]
$ hg clone --narrow ssh://user@dummy/master foo --include a/./c $ hg clone --narrow ssh://user@dummy/master foo --include a/./c
requesting all changes requesting all changes
abort: "." and ".." are not allowed in narrowspec paths abort: "." and ".." are not allowed in narrowspec paths
[255] [255]
Names with '.' in them are OK. Names with '.' in them are OK.
$ hg clone --narrow ssh://user@dummy/master $RANDOM --include a/.b/c $ hg clone --narrow ssh://user@dummy/master should-work --include a/.b/c
requesting all changes requesting all changes
adding changesets adding changesets
adding manifests adding manifests
adding file changes adding file changes
added 1 changesets with 0 changes to 0 files added 1 changesets with 0 changes to 0 files
new changesets * (glob) new changesets * (glob)
updating to branch default updating to branch default
0 files updated, 0 files merged, 0 files removed, 0 files unresolved 0 files updated, 0 files merged, 0 files removed, 0 files unresolved