This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2237

contrib: ban $RANDOM using check-code
ClosedPublic

Authored by durin42 on Feb 13 2018, 6:03 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHGc38e9248f531: contrib: ban $RANDOM using check-code
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 13 2018, 6:03 PM
martinvonz accepted this revision.Feb 13 2018, 6:26 PM
This revision is now accepted and ready to land.Feb 13 2018, 6:26 PM
Closed by commit rHGc38e9248f531: contrib: ban $RANDOM using check-code (authored by durin42). · Explain WhyFeb 13 2018, 6:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (1 line)

Diff 5666

contrib/check-code.py

(r'\|&', "don't use |&, use 2>&1"), (r'\|&', "don't use |&, use 2>&1"),
(r'\w = +\w', "only one space after = allowed"), (r'\w = +\w', "only one space after = allowed"),
(r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"), (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),
(r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"), (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
(r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"), (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
(r'grep.* -[ABC]', "don't use grep's context flags"), (r'grep.* -[ABC]', "don't use grep's context flags"),
(r'find.*-printf', (r'find.*-printf',
"don't use 'find -printf', it doesn't exist on BSD find(1)"), "don't use 'find -printf', it doesn't exist on BSD find(1)"),
(r'\$RANDOM ', "don't use bash-only $RANDOM to generate random values"),
], ],
# warnings # warnings
[ [
(r'^function', "don't use 'function', use old style"), (r'^function', "don't use 'function', use old style"),
(r'^diff.*-\w*N', "don't use 'diff -N'"), (r'^diff.*-\w*N', "don't use 'diff -N'"),
(r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"), (r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"),
(r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"), (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),
(r'kill (`|\$\()', "don't use kill, use killdaemons.py") (r'kill (`|\$\()', "don't use kill, use killdaemons.py")