This is an archive of the discontinued Mercurial Phabricator instance.

	Status	Author	Revision
	Closed	durin42	D2237 contrib: ban $RANDOM using check-code
	Closed	durin42	D2236 tests: remove use of bashism $RANDOM to fix test-narrow.t on non-bash shells

Diff 5659

	(r'\\|&', "don't use \|&, use 2>&1"),			(r'\\|&', "don't use \|&, use 2>&1"),
	(r'\w = +\w', "only one space after = allowed"),			(r'\w = +\w', "only one space after = allowed"),
	(r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),			(r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),
	(r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),			(r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
	(r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),			(r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
	(r'grep.* -[ABC]', "don't use grep's context flags"),			(r'grep.* -[ABC]', "don't use grep's context flags"),
	(r'find.*-printf',			(r'find.*-printf',
	"don't use 'find -printf', it doesn't exist on BSD find(1)"),			"don't use 'find -printf', it doesn't exist on BSD find(1)"),
				(r'\$RANDOM ', "don't use bash-only $RANDOM to generate random values"),
	],			],
	# warnings			# warnings
	[			[
	(r'^function', "don't use 'function', use old style"),			(r'^function', "don't use 'function', use old style"),
	(r'^diff.-\wN', "don't use 'diff -N'"),			(r'^diff.-\wN', "don't use 'diff -N'"),
	(r'\$PWD\|\${PWD}', "don't use $PWD, use `pwd`"),			(r'\$PWD\|\${PWD}', "don't use $PWD, use `pwd`"),
	(r'^([^"\'\n]\|("[^"\n]")\|(\'[^\'\n]\'))*\^', "^ must be quoted"),			(r'^([^"\'\n]\|("[^"\n]")\|(\'[^\'\n]\'))*\^', "^ must be quoted"),
	(r'kill (`\|\$\()', "don't use kill, use killdaemons.py")			(r'kill (`\|\$\()', "don't use kill, use killdaemons.py")