This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2240

histedit: convert bool to bytestring manually
ClosedPublic

Authored by durin42 on Feb 13 2018, 6:14 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG73621823a1ac: histedit: convert bool to bytestring manually
Summary

Yes, this format has 'True' and 'False' in it. I'm sorry, as it's
almost certainly my fault.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 13 2018, 6:14 PM
indygreg accepted this revision.Feb 13 2018, 11:55 PM
indygreg added a subscriber: indygreg.

Pretty sure I wrote this patch the other day...

This revision is now accepted and ready to land.Feb 13 2018, 11:55 PM
durin42 added a comment.Feb 13 2018, 11:56 PM

Yeah, but it failed tests. I suspect the difference between D2169 and this is the extra parens in my version?

Closed by commit rHG73621823a1ac: histedit: convert bool to bytestring manually (authored by durin42). · Explain WhyFeb 14 2018, 12:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/histedit.py (2 lines)

Diff 5676

hgext/histedit.py

else: else:
with self.repo.vfs("histedit-state", "w") as f: with self.repo.vfs("histedit-state", "w") as f:
self._write(f) self._write(f)
def _write(self, fp): def _write(self, fp):
fp.write('v1\n') fp.write('v1\n')
fp.write('%s\n' % node.hex(self.parentctxnode)) fp.write('%s\n' % node.hex(self.parentctxnode))
fp.write('%s\n' % node.hex(self.topmost)) fp.write('%s\n' % node.hex(self.topmost))
fp.write('%s\n' % self.keep) fp.write('%s\n' % ('True' if self.keep else 'False'))
fp.write('%d\n' % len(self.actions)) fp.write('%d\n' % len(self.actions))
for action in self.actions: for action in self.actions:
fp.write('%s\n' % action.tostate()) fp.write('%s\n' % action.tostate())
fp.write('%d\n' % len(self.replacements)) fp.write('%d\n' % len(self.replacements))
for replacement in self.replacements: for replacement in self.replacements:
fp.write('%s%s\n' % (node.hex(replacement[0]), ''.join(node.hex(r) fp.write('%s%s\n' % (node.hex(replacement[0]), ''.join(node.hex(r)
for r in replacement[1]))) for r in replacement[1])))
backupfile = self.backupfile backupfile = self.backupfile