This is an archive of the discontinued Mercurial Phabricator instance.

py3: whitelist more passing tests
ClosedPublic

Authored by durin42 on Feb 13 2018, 7:13 PM.

Download Raw Diff

Details

Reviewers

pulkit
indygreg

Group Reviewers

hg-reviewers

Commits

rHG0836c70ba5fa: py3: whitelist more passing tests
rHG6a6c919e9172: py3: whitelist more passing tests

Summary

I had some good success tonight with histedit
tests. test-histedit-fold.t is now low-hanging fruit: it is only
failing because the logic for setting environment variables in hook.py
is slightly busted. Specifically, hook.py line 142 should be making
sure it puts strings in the env dict, not bytes, to avoid b'' goo in
environment variables.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 13 2018, 7:13 PM

Herald added a reviewer: pulkit. · View Herald TranscriptFeb 13 2018, 7:13 PM

Herald added a reviewer: hg-reviewers. · View Herald Transcript

Herald added a subscriber: mercurial-devel. · View Herald Transcript

Can't accept this until D2244 is resolved.

indygreg accepted this revision.Feb 14 2018, 12:52 AM

This revision is now accepted and ready to land.Feb 14 2018, 12:52 AM

Closed by commit rHG6a6c919e9172: py3: whitelist more passing tests (authored by durin42). · Explain WhyFeb 14 2018, 12:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			contrib/python3-whitelist (4 lines)

Status	Author	Revision
Closed	durin42	D2249 py3: whitelist more passing tests
Closed	durin42	D2248 tests: port fakemergerecord to python3
Closed	durin42	D2247 tests: add some b-prefixes on local script in test-histedit-arguments
Closed	durin42	D2246 tests: add bytes prefixes to test-histedit-fold.t's local extension
Closed	durin42	D2245 ui: coerce system exception to bytes before dropping it in our StdioError
Closed	durin42	D2244 histedit: binascii.unhexlify (aka node.bin) throws new exception type on py3
Closed	durin42	D2243 histedit: fix silly bug that was unpacking a bytestr before writing it
Closed	durin42	D2242 py3: whitelist another 8 passing tests
Closed	durin42	D2241 histedit: modernize write of histedit-last-edit file
Closed	durin42	D2240 histedit: convert bool to bytestring manually
Closed	durin42	D2239 narrowcommands: more byteskwargs cleanup
Closed	durin42	D2238 narrowmerge: iterate over a copy of dict items so we can mutate the dict

Diff 5689

contrib/python3-whitelist

	test-execute-bit.t			test-execute-bit.t
	test-extra-filelog-entry.t			test-extra-filelog-entry.t
	test-filebranch.t			test-filebranch.t
	test-flags.t			test-flags.t
	test-generaldelta.t			test-generaldelta.t
	test-glog-topological.t			test-glog-topological.t
	test-gpg.t			test-gpg.t
	test-hghave.t			test-hghave.t
				test-histedit-arguments.t
				test-histedit-base.t
	test-histedit-bookmark-motion.t			test-histedit-bookmark-motion.t
	test-histedit-commute.t			test-histedit-commute.t
	test-histedit-drop.t			test-histedit-drop.t
	test-histedit-edit.t			test-histedit-edit.t
				test-histedit-fold-non-commute.t
	test-histedit-no-change.t			test-histedit-no-change.t
				test-histedit-non-commute.t
	test-histedit-obsolete.t			test-histedit-obsolete.t
	test-histedit-outgoing.t			test-histedit-outgoing.t
	test-http-clone-r.t			test-http-clone-r.t
	test-imports-checker.t			test-imports-checker.t
	test-inherit-mode.t			test-inherit-mode.t
	test-issue1089.t			test-issue1089.t
	test-issue1175.t			test-issue1175.t
	test-issue1306.t			test-issue1306.t

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	5673		Feb 13 2018, 7:13 PM	★	★
Diff 2	5689	rHG6a6c919e917257e94fc0ae0e996643a9059301d9	Feb 13 2018, 7:12 PM	★	★