Page MenuHomePhabricator

releasenotes: mention changeset with warning and abort
ClosedPublic

Authored by rishabhmadan96 on Feb 14 2018, 2:30 AM.

Details

Summary

Output the changeset hash with the warning/abort message just to know where things messed up.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rishabhmadan96 created this revision.Feb 14 2018, 2:30 AM
pulkit added a subscriber: pulkit.Feb 14 2018, 4:57 AM

I think ordering on the patches here is wrong. D2255 seems to be parent of this one. Also can you add related tests?

hgext/releasenotes.py
315

No need for node.hex(ctx.node()), just use ctx.

329

Same as above.

av6 added a subscriber: av6.Feb 14 2018, 5:01 AM
av6 added inline comments.
hgext/releasenotes.py
315

or ctx.hex()

pulkit added inline comments.Feb 14 2018, 5:04 AM
hgext/releasenotes.py
315

That's also okay. str(ctx) = ctx.hex()[:12]

durin42 accepted this revision.Mar 7 2018, 11:00 AM
This revision is now accepted and ready to land.Mar 7 2018, 11:00 AM
This revision was automatically updated to reflect the committed changes.