This is an archive of the discontinued Mercurial Phabricator instance.

releasenotes: replace abort with warning while parsing (issue5775)
ClosedPublic

Authored by rishabhmadan96 on Feb 14 2018, 2:31 AM.

Details

Summary

During the 4.5 development cycle, the extension broke on two different changesets.
This fixes the issue by ensuring that it just throws a warning when it encounters
unexpected behaviour, instead of aborting.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

rishabhmadan96 created this revision.Feb 14 2018, 2:31 AM
pulkit added a subscriber: pulkit.Feb 14 2018, 5:01 AM

This one is a bugfix, so please add the issue number in the commit message. Also add related tests as that will help make sure we don't encounter such problems again in future.

Yeah, my bad. I'll send an updated version with the suggested changes.

Friendly ping - should I expect an updated version of this series?

I totally forgot about this. I'll send them right away.

rishabhmadan96 edited the summary of this revision. (Show Details)Mar 4 2018, 2:17 PM
rishabhmadan96 retitled this revision from releasenotes: replace abort with warning while parsing to releasenotes: replace abort with warning while parsing (issue5775).
rishabhmadan96 updated this revision to Diff 6590.
durin42 accepted this revision.Mar 7 2018, 11:00 AM
This revision is now accepted and ready to land.Mar 7 2018, 11:00 AM
This revision was automatically updated to reflect the committed changes.