( )⚙ D2279 node: make bin() be a wrapper instead of just an alias

This is an archive of the discontinued Mercurial Phabricator instance.

node: make bin() be a wrapper instead of just an alias
ClosedPublic

Authored by durin42 on Feb 15 2018, 9:18 AM.

Details

Summary

This includes a full backout of 59affe7e and 30d0cb27. Per the review
of the former, we'd rather adapt the API to behave like it used to (at
least for now), and take a second run at it if it shows up in our
performance numbers. I ran perfrevlogindex with and without this
change and it didn't make a measurable difference, so maybe it's fine
(despite my intuition to the contrary).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 15 2018, 9:18 AM
martinvonz requested changes to this revision.Feb 15 2018, 10:55 AM
martinvonz added a subscriber: martinvonz.

Also make this commit back out 30d0cb279bac?

This revision now requires changes to proceed.Feb 15 2018, 10:55 AM
durin42 edited the summary of this revision. (Show Details)Feb 16 2018, 4:58 PM
durin42 updated this revision to Diff 5784.

Also make this commit back out 30d0cb279bac?

done

martinvonz accepted this revision.Feb 16 2018, 4:59 PM
This revision is now accepted and ready to land.Feb 16 2018, 4:59 PM
This revision was automatically updated to reflect the committed changes.