( )⚙ D2281 py3: whitelist another eight passing tests

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2281

py3: whitelist another eight passing tests
ClosedPublic

Authored by durin42 on Feb 15 2018, 9:18 AM.

Details

Reviewers
pulkit
yuja
Group Reviewers
hg-reviewers
Commits
rHGfbc29d9f552f: py3: whitelist another eight passing tests
rHGc9f30dcc3f43: py3: whitelist another eight passing tests
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Feb 15 2018, 9:18 AM
durin42 updated this revision to Diff 5765.Feb 15 2018, 10:47 AM
pulkit requested changes to this revision.Feb 15 2018, 12:44 PM
pulkit added inline comments.
hgext/remotenames.py
65

unrelated change? This should be folded in previous patch I think.

This revision now requires changes to proceed.Feb 15 2018, 12:44 PM
durin42 marked an inline comment as done.Feb 15 2018, 12:54 PM
durin42 updated this revision to Diff 5769.
durin42 added a comment.Feb 15 2018, 12:54 PM

thanks, I had an amend misfire

durin42 retitled this revision from py3: whitelist another six passing tests to py3: whitelist another eight passing tests.Feb 16 2018, 10:00 PM
durin42 updated this revision to Diff 5791.
yuja accepted this revision.Feb 16 2018, 10:37 PM
Closed by commit rHGc9f30dcc3f43: py3: whitelist another eight passing tests (authored by durin42). · Explain WhyFeb 16 2018, 10:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/python3-whitelist (6 lines)
Mhgext/remotenames.py (2 lines)

Diff 5765

contrib/python3-whitelist

test-bookmarks-rebase.t test-bookmarks-rebase.t
test-bookmarks-strip.t test-bookmarks-strip.t
test-branch-option.t test-branch-option.t
test-branch-tag-confict.t test-branch-tag-confict.t
test-bundle-phases.t test-bundle-phases.t
test-bundle-vs-outgoing.t test-bundle-vs-outgoing.t
test-casecollision.t test-casecollision.t
test-cat.t test-cat.t
test-censor.t
test-changelog-exec.t test-changelog-exec.t
test-check-commit.t test-check-commit.t
test-check-execute.t test-check-execute.t
test-check-module-imports.t test-check-module-imports.t
test-check-pyflakes.t test-check-pyflakes.t
test-check-pylint.t test-check-pylint.t
test-check-shbang.t test-check-shbang.t
test-children.t test-children.t
test-exchange-obsmarkers-case-D2.t test-exchange-obsmarkers-case-D2.t
test-exchange-obsmarkers-case-D3.t test-exchange-obsmarkers-case-D3.t
test-exchange-obsmarkers-case-D4.t test-exchange-obsmarkers-case-D4.t
test-execute-bit.t test-execute-bit.t
test-extra-filelog-entry.t test-extra-filelog-entry.t
test-filebranch.t test-filebranch.t
test-flags.t test-flags.t
test-generaldelta.t test-generaldelta.t
test-git-export.t
test-glog-topological.t test-glog-topological.t
test-gpg.t test-gpg.t
test-hghave.t test-hghave.t
test-histedit-arguments.t test-histedit-arguments.t
test-histedit-base.t test-histedit-base.t
test-histedit-bookmark-motion.t test-histedit-bookmark-motion.t
test-histedit-commute.t test-histedit-commute.t
test-histedit-drop.t test-histedit-drop.t
test-push-checkheads-unpushed-D6.t test-push-checkheads-unpushed-D6.t
test-push-checkheads-unpushed-D7.t test-push-checkheads-unpushed-D7.t
test-push-warn.t test-push-warn.t
test-rebase-bookmarks.t test-rebase-bookmarks.t
test-rebase-check-restore.t test-rebase-check-restore.t
test-rebase-inmemory.t test-rebase-inmemory.t
test-rebase-issue-noparam-single-rev.t test-rebase-issue-noparam-single-rev.t
test-rebase-legacy.t test-rebase-legacy.t
test-rebase-named-branches.t
test-rebase-pull.t test-rebase-pull.t
test-rebase-transaction.t test-rebase-transaction.t
test-record.t test-record.t
test-remove.t test-remove.t
test-rename-after-merge.t test-rename-after-merge.t
test-rename-dir-merge.t test-rename-dir-merge.t
test-rename-merge1.t test-rename-merge1.t
test-rename.t test-rename.t
test-repair-strip.t
test-revert-flags.t test-revert-flags.t
test-revert-unknown.t test-revert-unknown.t
test-revlog-group-emptyiter.t test-revlog-group-emptyiter.t
test-revlog-mmapindex.t test-revlog-mmapindex.t
test-revlog-packentry.t test-revlog-packentry.t
test-revset-dirstate-parents.t test-revset-dirstate-parents.t
test-revset-outgoing.t test-revset-outgoing.t
test-run-tests.py test-run-tests.py
test-serve.t test-serve.t
test-show-stack.t test-show-stack.t
test-show.t test-show.t
test-simple-update.t test-simple-update.t
test-single-head.t test-single-head.t
test-sparse-clear.t test-sparse-clear.t
test-sparse-merges.t test-sparse-merges.t
test-sparse-requirement.t test-sparse-requirement.t
test-sparse-verbose-json.t test-sparse-verbose-json.t
test-ssh-clone-r.t test-ssh-clone-r.t
test-ssh-proto.t
test-sshserver.py
test-status-terse.t test-status-terse.t
test-strip-cross.t test-strip-cross.t
test-strip.t test-strip.t
test-unamend.t test-unamend.t
test-uncommit.t test-uncommit.t
test-unified-test.t test-unified-test.t
test-unrelated-pull.t test-unrelated-pull.t
test-up-local-change.t test-up-local-change.t
test-update-branches.t test-update-branches.t
test-update-dest.t test-update-dest.t
test-update-issue1456.t test-update-issue1456.t
test-update-names.t test-update-names.t
test-update-reverse.t test-update-reverse.t
test-win32text.t test-win32text.t
test-xdg.t test-xdg.t

hgext/remotenames.py

configitem('remotenames', 'bookmarks', configitem('remotenames', 'bookmarks',
default=True, default=True,
) )
configitem('remotenames', 'branches', configitem('remotenames', 'branches',
default=True, default=True,
) )
class lazyremotenamedict(DictMixin): class lazyremotenamedict(dictmixin):
pulkitUnsubmitted
Done

unrelated change? This should be folded in previous patch I think.

pulkit: unrelated change? This should be folded in previous patch I think.
""" """
Read-only dict-like Class to lazily resolve remotename entries Read-only dict-like Class to lazily resolve remotename entries
We are doing that because remotenames startup was slow. We are doing that because remotenames startup was slow.
We lazily read the remotenames file once to figure out the potential entries We lazily read the remotenames file once to figure out the potential entries
and store them in self.potentialentries. Then when asked to resolve an and store them in self.potentialentries. Then when asked to resolve an
entry, if it is not in self.potentialentries, then it isn't there, if it entry, if it is not in self.potentialentries, then it isn't there, if it
is in self.potentialentries we resolve it and store the result in is in self.potentialentries we resolve it and store the result in