This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: update diff property even if we choose not to create a new diff

Authored by quark on Aug 4 2017, 3:55 PM.



The diff property contains metadata like "HG Node". Previously we skip
uploading a new diff if we are sure that the old patch and new patch have a
same content. That has issues when a pusher adds an obsmarker using the old
"HG Node" stored in the old diff.

This patch adds logic to update the diff property so "HG Node" gets updated
to prevent that issue.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Aug 4 2017, 3:55 PM
durin42 accepted this revision.Aug 4 2017, 5:37 PM
This revision is now accepted and ready to land.Aug 4 2017, 5:37 PM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Aug 12 2017, 11:28 PM
yuja added inline comments.

writediffproperties() is called twice. Perhaps one of them should be deleted.