( )⚙ D2312 hgweb: header dict entries are native strings

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2312

hgweb: header dict entries are native strings
ClosedPublic

Authored by durin42 on Feb 18 2018, 12:42 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGd18c0cf5f3ab: hgweb: header dict entries are native strings
Summary
  1. skip-blame just marking some native strings

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 18 2018, 12:42 AM
pulkit added a subscriber: pulkit.Feb 18 2018, 6:54 AM

This one also should be # skip-blame.

durin42 edited the summary of this revision. (Show Details)Feb 18 2018, 9:37 AM
indygreg accepted this revision.Feb 18 2018, 11:21 AM
This revision is now accepted and ready to land.Feb 18 2018, 11:21 AM
Closed by commit rHGd18c0cf5f3ab: hgweb: header dict entries are native strings (authored by durin42). · Explain WhyFeb 18 2018, 11:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/common.py (4 lines)

Diff 5881

mercurial/hgweb/common.py

""" """
return userlist == ['*'] or username in userlist return userlist == ['*'] or username in userlist
def checkauthz(hgweb, req, op): def checkauthz(hgweb, req, op):
'''Check permission for operation based on request data (including '''Check permission for operation based on request data (including
authentication info). Return if op allowed, else raise an ErrorResponse authentication info). Return if op allowed, else raise an ErrorResponse
exception.''' exception.'''
user = req.env.get('REMOTE_USER') user = req.env.get(r'REMOTE_USER')
deny_read = hgweb.configlist('web', 'deny_read') deny_read = hgweb.configlist('web', 'deny_read')
if deny_read and (not user or ismember(hgweb.repo.ui, user, deny_read)): if deny_read and (not user or ismember(hgweb.repo.ui, user, deny_read)):
raise ErrorResponse(HTTP_UNAUTHORIZED, 'read not authorized') raise ErrorResponse(HTTP_UNAUTHORIZED, 'read not authorized')
allow_read = hgweb.configlist('web', 'allow_read') allow_read = hgweb.configlist('web', 'allow_read')
if allow_read and (not ismember(hgweb.repo.ui, user, allow_read)): if allow_read and (not ismember(hgweb.repo.ui, user, allow_read)):
raise ErrorResponse(HTTP_UNAUTHORIZED, 'read not authorized') raise ErrorResponse(HTTP_UNAUTHORIZED, 'read not authorized')
if op == 'pull' and not hgweb.allowpull: if op == 'pull' and not hgweb.allowpull:
raise ErrorResponse(HTTP_UNAUTHORIZED, 'pull not authorized') raise ErrorResponse(HTTP_UNAUTHORIZED, 'pull not authorized')
elif op == 'pull' or op is None: # op is None for interface requests elif op == 'pull' or op is None: # op is None for interface requests
return return
# enforce that you can only push using POST requests # enforce that you can only push using POST requests
if req.env['REQUEST_METHOD'] != 'POST': if req.env[r'REQUEST_METHOD'] != r'POST':
msg = 'push requires POST request' msg = 'push requires POST request'
raise ErrorResponse(HTTP_METHOD_NOT_ALLOWED, msg) raise ErrorResponse(HTTP_METHOD_NOT_ALLOWED, msg)
# require ssl by default for pushing, auth info cannot be sniffed # require ssl by default for pushing, auth info cannot be sniffed
# and replayed # and replayed
scheme = req.env.get('wsgi.url_scheme') scheme = req.env.get('wsgi.url_scheme')
if hgweb.configbool('web', 'push_ssl') and scheme != 'https': if hgweb.configbool('web', 'push_ssl') and scheme != 'https':
raise ErrorResponse(HTTP_FORBIDDEN, 'ssl required') raise ErrorResponse(HTTP_FORBIDDEN, 'ssl required')