This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	5862		Feb 18 2018, 8:31 AM	★	★
Diff 2	5879		Feb 18 2018, 9:41 AM	★	★
Diff 3	5888	rHG7e025d4c6f611bbcc2191ad54215332a8cc71aba	Feb 18 2018, 7:52 AM	★	★

Status	Author	Revision
Abandoned	pulkit	D2334 py3: use print as a function in test-mq-push-fail.t
Closed	pulkit	D2333 py3: make sure we open the files in bytes mode
Closed	pulkit	D2332 py3: use range instead of xrange on py3 in tests/test-ui-verbosity.py
Closed	pulkit	D2331 py3: use range instead of xrange in tests/test-revset2.t
Closed	pulkit	D2330 py3: use range instead of xrange in tests/test-mq-qimport.t
Closed	pulkit	D2329 py3: use range instead of xrange in tests/test-issue4074.t
Closed	pulkit	D2328 py3: use range instead of xrange in tests/test-convert-mtn.t
Closed	pulkit	D2327 py3: use range instead of xrange in tests/test-commandserver.t
Closed	pulkit	D2326 py3: use range instead of xrange in tests/test-walk.t
Closed	pulkit	D2325 py3: use range instead of xrange in tests/test-mq-missingfiles.t
Closed	pulkit	D2324 py3: use range instead of xrange on py3 in tests/test-filecache.py
Closed	pulkit	D2323 py3: use range instead on xrange on py3 in tests/test-atomictempfile.py
Closed	pulkit	D2322 py3: add b'' prefix in test-mq-qrefresh-replace-log-message.t
Closed	pulkit	D2321 py3: add b'' prefixes in test-mq-eol.t
Closed	pulkit	D2320 py3: explicitly convert result of dict.items() into list
Closed	pulkit	D2319 py3: use pycompat.byteskwargs() to convert opts keys to bytes

Diff 5888

	return (os.lstat(f).st_mode & 0o100 != 0)			return (os.lstat(f).st_mode & 0o100 != 0)

	def setflags(f, l, x):			def setflags(f, l, x):
	st = os.lstat(f)			st = os.lstat(f)
	s = st.st_mode			s = st.st_mode
	if l:			if l:
	if not stat.S_ISLNK(s):			if not stat.S_ISLNK(s):
	# switch file to link			# switch file to link
	fp = open(f)			fp = open(f, 'wb')
				yujaUnsubmitted Not Done Two more missing 'b's, here yuja: Two more missing 'b's, here
				yujaUnsubmitted Not Done should be 'rb' Fixed in flight. yuja: should be 'rb' Fixed in flight.
	data = fp.read()			data = fp.read()
	fp.close()			fp.close()
	unlink(f)			unlink(f)
	try:			try:
	os.symlink(data, f)			os.symlink(data, f)
	except OSError:			except OSError:
	# failed to make a link, rewrite file			# failed to make a link, rewrite file
	fp = open(f, "w")			fp = open(f, "wb")
				yujaUnsubmitted Not Done and here. yuja: and here.
	fp.write(data)			fp.write(data)
	fp.close()			fp.close()
	# no chmod needed at this point			# no chmod needed at this point
	return			return
	if stat.S_ISLNK(s):			if stat.S_ISLNK(s):
	# switch link to file			# switch link to file
	data = os.readlink(f)			data = os.readlink(f)
	unlink(f)			unlink(f)
	fp = open(f, "w")			fp = open(f, "wb")
	fp.write(data)			fp.write(data)
	fp.close()			fp.close()
	s = 0o666 & ~umask # avoid restatting for chmod			s = 0o666 & ~umask # avoid restatting for chmod

	sx = s & 0o100			sx = s & 0o100
	if st.st_nlink > 1 and bool(x) != bool(sx):			if st.st_nlink > 1 and bool(x) != bool(sx):
	# the file is a hardlink, break it			# the file is a hardlink, break it
	with open(f, "rb") as fp:			with open(f, "rb") as fp: