This is an archive of the discontinued Mercurial Phabricator instance.

py3: make sure we open the files in bytes mode
ClosedPublic

Authored by pulkit on Feb 18 2018, 8:31 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 18 2018, 8:31 AM
yuja requested changes to this revision.Feb 18 2018, 9:12 AM
yuja added a subscriber: yuja.
yuja added inline comments.
mercurial/posix.py
116

Two more missing 'b's, here

124

and here.

This revision now requires changes to proceed.Feb 18 2018, 9:12 AM
pulkit updated this revision to Diff 5879.Feb 18 2018, 9:41 AM
indygreg accepted this revision.Feb 18 2018, 11:32 AM
This revision was automatically updated to reflect the committed changes.
yuja added inline comments.Feb 19 2018, 7:00 AM
mercurial/posix.py
116

should be 'rb'

Fixed in flight.