This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2360

py3: make sure we open file in bytes mode
ClosedPublic

Authored by pulkit on Feb 21 2018, 3:55 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG0f36926b2651: py3: make sure we open file in bytes mode
Summary
  1. skip-blame because we appended only b'' which stands for bytes

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 21 2018, 3:55 AM
yuja accepted this revision.Feb 21 2018, 7:41 AM
This revision is now accepted and ready to land.Feb 21 2018, 7:41 AM
yuja added a comment.Feb 21 2018, 7:42 AM

skip-blame because we appended only b'' which stands for bytes

Untrue. :) Dropped this comment in flight.

Closed by commit rHG0f36926b2651: py3: make sure we open file in bytes mode (authored by pulkit). · Explain WhyFeb 21 2018, 7:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-ui-color.py (4 lines)

Diff 5941

tests/test-ui-color.py

testui = uimod.ui() testui = uimod.ui()
testui.pushbuffer() testui.pushbuffer()
testui.write((b'buffered\n')) testui.write((b'buffered\n'))
testui.warn((b'warning\n')) testui.warn((b'warning\n'))
testui.write_err(b'error\n') testui.write_err(b'error\n')
print(repr(testui.popbuffer())) print(repr(testui.popbuffer()))
# test dispatch.dispatch with the same ui object # test dispatch.dispatch with the same ui object
hgrc = open(os.environ["HGRCPATH"], 'w') hgrc = open(os.environ["HGRCPATH"], 'wb')
hgrc.write(b'[extensions]\n') hgrc.write(b'[extensions]\n')
hgrc.write(b'color=\n') hgrc.write(b'color=\n')
hgrc.close() hgrc.close()
ui_ = uimod.ui.load() ui_ = uimod.ui.load()
ui_.setconfig(b'ui', b'formatted', b'True') ui_.setconfig(b'ui', b'formatted', b'True')
# we're not interested in the output, so write that to devnull # we're not interested in the output, so write that to devnull
ui_.fout = open(os.devnull, 'w') ui_.fout = open(os.devnull, 'wb')
# call some arbitrary command just so we go through # call some arbitrary command just so we go through
# color's wrapped _runcommand twice. # color's wrapped _runcommand twice.
def runcmd(): def runcmd():
dispatch.dispatch(dispatch.request([b'version', b'-q'], ui_)) dispatch.dispatch(dispatch.request([b'version', b'-q'], ui_))
runcmd() runcmd()
print("colored? %s" % (ui_._colormode is not None)) print("colored? %s" % (ui_._colormode is not None))
runcmd() runcmd()
print("colored? %s" % (ui_._colormode is not None)) print("colored? %s" % (ui_._colormode is not None))