This is an archive of the discontinued Mercurial Phabricator instance.

py3: make sure we open file in bytes mode
ClosedPublic

Authored by pulkit on Feb 21 2018, 3:55 AM.

Details

Summary
  1. skip-blame because we appended only b'' which stands for bytes

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Feb 21 2018, 3:55 AM
yuja accepted this revision.Feb 21 2018, 7:41 AM
This revision is now accepted and ready to land.Feb 21 2018, 7:41 AM
yuja added a comment.Feb 21 2018, 7:42 AM

skip-blame because we appended only b'' which stands for bytes

Untrue. :) Dropped this comment in flight.

This revision was automatically updated to reflect the committed changes.