This is an archive of the discontinued Mercurial Phabricator instance.

sshpeer: move logic for sending a request into a new function
ClosedPublic

Authored by indygreg on Feb 21 2018, 5:08 PM.

Details

Summary

The **args being used to pass arbitrary command arguments is limiting
because it makes it harder to control behavior of the function.

We factor most of _callstream() into a new function that doesn't
use **args.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 21 2018, 5:08 PM
yuja accepted this revision.Feb 22 2018, 9:05 AM
This revision is now accepted and ready to land.Feb 22 2018, 9:05 AM
This revision was automatically updated to reflect the committed changes.