This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: document the wonky push protocol for SSH
ClosedPublic

Authored by indygreg on Feb 21 2018, 10:23 PM.

Details

Summary

It took me several minutes to figure out how the "unbundle"
protocol worked. It turns out that the SSH protocol handler
sends an empty reply that is interpreted as "OK to send" and
only then does the client send the bundle payload.

On top of that, the response is different depending on whether
the operation was successful or not. I nearly pulled out my hair
deciphering this.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 21 2018, 10:23 PM
yuja accepted this revision.Feb 22 2018, 9:05 AM
This revision is now accepted and ready to land.Feb 22 2018, 9:05 AM
This revision was automatically updated to reflect the committed changes.