This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2387

narrowbundle2: use native string to get kwargs from dict
ClosedPublic

Authored by durin42 on Feb 21 2018, 11:25 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGcd4f13f1ea2f: narrowbundle2: use native string to get kwargs from dict
rHGac7873dea67f: narrowbundle2: use native string to get kwargs from dict
Summary
  1. skip-blame just some r prefixes on strings

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Feb 21 2018, 11:25 PM
indygreg accepted this revision.Feb 22 2018, 1:28 AM
This revision is now accepted and ready to land.Feb 22 2018, 1:28 AM
Closed by commit rHGac7873dea67f: narrowbundle2: use native string to get kwargs from dict (authored by durin42). · Explain WhyFeb 22 2018, 1:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/narrowbundle2.py (4 lines)

Diff 5986

hgext/narrow/narrowbundle2.py

if v in changegroup.supportedoutgoingversions(repo)] if v in changegroup.supportedoutgoingversions(repo)]
if not cgversions: if not cgversions:
raise ValueError(_('no common changegroup version')) raise ValueError(_('no common changegroup version'))
version = max(cgversions) version = max(cgversions)
else: else:
raise ValueError(_("server does not advertise changegroup version," raise ValueError(_("server does not advertise changegroup version,"
" can't negotiate support for ellipsis nodes")) " can't negotiate support for ellipsis nodes"))
include = sorted(filter(bool, kwargs.get('includepats', []))) include = sorted(filter(bool, kwargs.get(r'includepats', [])))
exclude = sorted(filter(bool, kwargs.get('excludepats', []))) exclude = sorted(filter(bool, kwargs.get(r'excludepats', [])))
newmatch = narrowspec.match(repo.root, include=include, exclude=exclude) newmatch = narrowspec.match(repo.root, include=include, exclude=exclude)
if not repo.ui.configbool("experimental", "narrowservebrokenellipses"): if not repo.ui.configbool("experimental", "narrowservebrokenellipses"):
outgoing = exchange._computeoutgoing(repo, heads, common) outgoing = exchange._computeoutgoing(repo, heads, common)
if not outgoing.missing: if not outgoing.missing:
return return
def wrappedgetbundler(orig, *args, **kwargs): def wrappedgetbundler(orig, *args, **kwargs):
bundler = orig(*args, **kwargs) bundler = orig(*args, **kwargs)
bundler._narrow_matcher = lambda : newmatch bundler._narrow_matcher = lambda : newmatch