This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2423

templatekw: use ctx.rev() instead of casting context to int
ClosedPublic

Authored by indygreg on Feb 24 2018, 2:30 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGd65642840c6f: templatekw: use ctx.rev() instead of casting context to int
Summary

basectx has int implemented. Per mailing list discussion
with Yuya, we don't like having this implemented because it is
too much magic and in some cases rev() will return None, which
isn't an int.

So convert a '%d' % ctx to ctx.rev() instead.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 24 2018, 2:30 PM
yuja accepted this revision.Feb 24 2018, 8:36 PM
This revision is now accepted and ready to land.Feb 24 2018, 8:36 PM
Closed by commit rHGd65642840c6f: templatekw: use ctx.rev() instead of casting context to int (authored by indygreg). · Explain WhyFeb 24 2018, 8:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/templatekw.py (2 lines)

Diff 6055

mercurial/templatekw.py

f = _showlist('bookmark', bookmarks, args) f = _showlist('bookmark', bookmarks, args)
return _hybrid(f, bookmarks, makemap, pycompat.identity) return _hybrid(f, bookmarks, makemap, pycompat.identity)
@templatekeyword('children') @templatekeyword('children')
def showchildren(**args): def showchildren(**args):
"""List of strings. The children of the changeset.""" """List of strings. The children of the changeset."""
args = pycompat.byteskwargs(args) args = pycompat.byteskwargs(args)
ctx = args['ctx'] ctx = args['ctx']
childrevs = ['%d:%s' % (cctx, cctx) for cctx in ctx.children()] childrevs = ['%d:%s' % (cctx.rev(), cctx) for cctx in ctx.children()]
return showlist('children', childrevs, args, element='child') return showlist('children', childrevs, args, element='child')
# Deprecated, but kept alive for help generation a purpose. # Deprecated, but kept alive for help generation a purpose.
@templatekeyword('currentbookmark') @templatekeyword('currentbookmark')
def showcurrentbookmark(**args): def showcurrentbookmark(**args):
"""String. The active bookmark, if it is associated with the changeset. """String. The active bookmark, if it is associated with the changeset.
(DEPRECATED)""" (DEPRECATED)"""
return showactivebookmark(**args) return showactivebookmark(**args)