This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2430

split: use ctx.rev() instead of %d % ctx
ClosedPublic

Authored by indygreg on Feb 24 2018, 2:30 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG83bade6206d4: split: use ctx.rev() instead of %d % ctx
Summary

And rename a variable for clarity while we're here.

This is part of our effort to wean off basectx.int.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 24 2018, 2:30 PM
yuja accepted this revision.Feb 24 2018, 8:36 PM
This revision is now accepted and ready to land.Feb 24 2018, 8:36 PM
Closed by commit rHG83bade6206d4: split: use ctx.rev() instead of %d % ctx (authored by indygreg). · Explain WhyFeb 24 2018, 8:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/split.py (4 lines)

Diff 6062

hgext/split.py

if not committed: if not committed:
raise error.Abort(_('cannot split an empty revision')) raise error.Abort(_('cannot split an empty revision'))
scmutil.cleanupnodes(repo, {ctx.node(): [c.node() for c in committed]}, scmutil.cleanupnodes(repo, {ctx.node(): [c.node() for c in committed]},
operation='split') operation='split')
return committed[-1] return committed[-1]
def dorebase(ui, repo, src, dest): def dorebase(ui, repo, src, destctx):
rebase.rebase(ui, repo, rev=[revsetlang.formatspec('%ld', src)], rebase.rebase(ui, repo, rev=[revsetlang.formatspec('%ld', src)],
dest=revsetlang.formatspec('%d', dest)) dest=revsetlang.formatspec('%d', destctx.rev()))