This is an archive of the discontinued Mercurial Phabricator instance.

tests: make get-with-headers flush after print() calls
AbandonedPublic

Authored by durin42 on Mar 2 2018, 9:50 AM.

Details

Reviewers
pulkit
yuja
Group Reviewers
hg-reviewers
Summary

This avoids some output buffering problems on Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Mar 2 2018, 9:50 AM
pulkit accepted this revision.Mar 2 2018, 10:18 AM
yuja requested changes to this revision.Mar 2 2018, 11:04 AM
yuja added a subscriber: yuja.

Appears that this disclosed some weird issue:

--- tests/test-hgweb-commands.t
+++ tests/test-hgweb-commands.t.err
@@ -2116,7 +2116,10 @@
   $ get-with-headers.py $LOCALIP:$HGPORT '?cmd=capabilities' | dd ibs=75 count=1 2> /dev/null; echo
   200 Script output follows

-  lookup changegroupsubset branchmap pushkey known
+  close failed in file object destructor:
+  sys.excepthook is missing
+  lost sys.stderr
+
This revision now requires changes to proceed.Mar 2 2018, 11:04 AM
durin42 abandoned this revision.Mar 2 2018, 4:33 PM