Page Menu
Home
Phabricator
This is an archive of the discontinued Mercurial Phabricator instance.
Differential
D2554
templatekw: fix dict construction in _showlist to not mix bytes and strs
Closed
Public
Authored by
durin42
on Mar 2 2018, 9:50 AM.
Download Raw Diff
Tags
None
Subscribers
mercurial-devel
Details
Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG45f149bf08d1: templatekw: fix dict construction in _showlist to not mix bytes and strs
Summary
What we had was fine on Python 2, but was slightly wrong on Python
This works on both.
Diff Detail
Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped
Event Timeline
durin42
created this revision.
Mar 2 2018, 9:50 AM
Herald
added a reviewer:
hg-reviewers
.
·
View Herald Transcript
Mar 2 2018, 9:50 AM
Herald
added a subscriber:
mercurial-devel
.
·
View Herald Transcript
durin42
added a child revision:
D2555: py3: two more passing tests
.
Mar 2 2018, 9:50 AM
pulkit
accepted this revision.
Mar 2 2018, 10:28 AM
Closed by commit
rHG45f149bf08d1: templatekw: fix dict construction in _showlist to not mix bytes and strs
(authored by
durin42
).
·
Explain Why
Mar 2 2018, 11:18 AM
This revision was automatically updated to reflect the committed changes.