This is an archive of the discontinued Mercurial Phabricator instance.

url: more bytes/unicodes fussing in url.py around auth handling
ClosedPublic

Authored by durin42 on Mar 3 2018, 2:31 PM.

Details

Summary

Once again, these methods are a little annoying to handle because they
can get unicodes or bytes depending on who's calling. I think we can
probably clean this up a TON once we can run something like pytype and
do typechecking of our Python, but until then this is going to be the
easy way out. This fixes test-http-bundle1.t.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Mar 3 2018, 2:31 PM
yuja accepted this revision.Mar 3 2018, 2:43 PM
This revision is now accepted and ready to land.Mar 3 2018, 2:43 PM
This revision was automatically updated to reflect the committed changes.